Brian/apy rescue fix (#270)

Fix shares math for APYRescue

contracts/product/APYRescue.sol

@@ -69,7 +69,7 @@ contract APYRescue is Ownable {
         // Must approve _amount to this contract to be transferred
         apyToken.transferFrom(msg.sender, address(this), _amount);
 
-        shares[msg.sender] += shares[msg.sender].add(_amount);
+        shares[msg.sender] = shares[msg.sender].add(_amount);
         totalShares = totalShares.add(_amount);
     }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@setprotocol/set-protocol-v2",
-  "version": "0.11.2",
+  "version": "0.11.3",
   "description": "",
   "main": "dist",
   "files": [

test/product/apyRescue.spec.ts

@@ -90,8 +90,8 @@ describe("APYRescue", () => {
       await setup.usdc.connect(owner.wallet).approve(issuanceModule.address, usdc(150));
       await issuanceModule.connect(owner.wallet).issue(apyToken.address, ether(1.5), owner.address);
 
-      subjectAmount = ether(1);
-      await apyToken.approve(apyRescue.address, subjectAmount);
+      subjectAmount = ether(.5);
+      await apyToken.approve(apyRescue.address, ether(1));
 
       subjectCaller = owner;
     });
@@ -120,6 +120,22 @@ describe("APYRescue", () => {
       expect(postBalance).to.eq(preBalance.add(subjectAmount));
     });
 
+    describe("when multiple deposits are performed", async () => {
+      beforeEach(async () => {
+        await subject();
+      });
+
+      it("should have the correct amount of shares", async () => {
+        const preBalance = await apyRescue.shares(owner.address);
+
+        await subject();
+
+        const postBalance = await apyRescue.shares(owner.address);
+
+        expect(postBalance).to.eq(preBalance.add(subjectAmount));
+      });
+    });
+
     describe("when the rescue has already been performed", async () => {
       beforeEach(async () => {
         await apyRescue.connect(subjectCaller.wallet).deposit(subjectAmount);