New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrote APYRescue as well as TokenEnabler contract. Included mainnet fo… #268
Conversation
…rking tests of current state to make sure that strategy will be successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two major suggestions (can discuss):
- Support Sets with more than one component.
- Add a withdraw Set flow.
Also, a few test cases are missing. Let's add those.
}); | ||
}); | ||
|
||
describe("#withdrawRescuedFunds", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing cases: Withdraw before rescue is done.
…e recovery has been executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the missing cases in the withdrawRescuedFunds
tests. Rest LGTM.
… date block state than rest of tests.
…rking tests of current state to make sure that strategy will be successful.
Code Review Processes
New Feature Review
Before submitting a pull request for new review, make sure the following is done:
README Checks
Code Checks
Broader Considerations