Added an option to sign using SAD in addition to OTP #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
reviewed
Oct 4, 2022
JanSlabon
requested changes
Oct 4, 2022
Minor code styling fixes
|
Thank you for this PR. I fixed the minor styling issues for you. Also I removed the setSigningMethod() and simply decide internaly by checking the given properties which signing method is to use. @Binternet What do you think about this change? |
JanSlabon
approved these changes
Oct 4, 2022
|
@MaximilianKresse great change and does the job much better, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.