Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Giphy player like Facebook #1

Merged
merged 3 commits into from
Aug 18, 2016

Conversation

lelinhtinh
Copy link
Contributor

@SethClydesdale
Copy link
Owner

That's a brilliant idea ! 👍

I tested it and it works perfectly. 😍 The only thing that I'd recommend changing is the following part, because it's version specific. ( .post-entry is a punbb only class )

var $giphyImg = $('.post-entry img[src*=".giphy.com/media/"][src$="giphy.gif"]');

Something like this should work perfectly cross-version :

var $giphyImg = $('.postbody, .post-entry').find('img[src*=".giphy.com/media/"][src$="giphy.gif"]');

I think it'd be great to distribute this side-by-side with the SCEditor button. Is it alright with you if I include your plugin in my upcoming tutorial ? You'll be credited of course. Let me know 😄

@lelinhtinh
Copy link
Contributor Author

If so I should remove gifactif.key or keep it?

@SethClydesdale
Copy link
Owner

@baivong Thanks, and great work ! ^^ Since this will most likely be used alongside the button plugin, it should be fine, because if the user ever changes their API key it'll be changed in your plugin as well. 😉

@lelinhtinh
Copy link
Contributor Author

I do not understand the meaning side-by-side, but you are free to use it in your way. 😆

@SethClydesdale SethClydesdale merged commit a8bbfbd into SethClydesdale:master Aug 18, 2016
@SethClydesdale
Copy link
Owner

"side-by-side" pretty much means two things that are close together -- similar to the word "alongside". What I meant is I'll share both codes in the same topic. I'll do the same in the repository too, once I add instructions to the readme. ^^

Thanks again for your contribution. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants