Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More description formatting and 2 new options #23

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

rhullah
Copy link
Contributor

@rhullah rhullah commented Dec 6, 2023

Perform additional formatting w/ options on the description:

  • remove HTML comments which are often added by the 'Generate release notes' button
  • trim the resulting description
  • reduce consecutive whitespace/newlines into a minimum of 2 to allow separation in paragraphs
  • parse common Github URLs to more appropriate display
  • add options:
    • max_description: Discord allows a max of 4096, so allow for more but prevent from going over with ellipses and link "buffer"
    • reduce_headings: Enabling this will actually perform what looks like was intended of converting H2's to bold and H3's to bold and underline for a more reduced display. I left it defaulted at false to mimic it's current state which didn't seem to actually perform the heading conversion. I couldn't find a reason why the original code wasn't performing the heading conversion, but the new regex does work.

rhullah and others added 10 commits December 6, 2023 12:03
@rhullah
Copy link
Contributor Author

rhullah commented Dec 11, 2023

@SethCohen, any chance of getting this merged in?

@SethCohen SethCohen merged commit 8ca9da2 into SethCohen:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants