Segmentation fault on isfloat() #1
Comments
|
Hmm. This is very difficult to debug without knowing what input caused the segfault. Is this repeatable (given the same input you always get a segfault)? If so, is it possible for you to give me the input, or at least point me to the code you are using that generates the input? I'd like to try and reproduce on my machine to see if I can solve the issue. BTW, the "safe" in "safe_float" refers to the fact that it does bounds checking so you won't get an overflow error, and it gives better precision for large numbers. It is not related to segfaults... I would not consider any segfault to be normal. |
|
Thanks for the answer. |
|
Hello, for line in open("myFile.arpa")
element = line.rstrip().split()[-1]
if fastnumbers.isfloat(element) :
print("its a log probabilitie")
else :
print("it's a word")Like it's getting nowhere I'll close the issue until may be someone someday reopen it . |
When dealing with unicode input, the python object needs to be converted to a bytes object before being converted to a character array. Previously, fastnumbers was relying on the python object remaining in memory when dealing with character arrays because a strcpy was not performed. Because extracting the character array from unicode requires a temporary python object which is quickly de-referenced, this is not a safe technique; the segfault is rare because python garbage collects de-references objects only periodically, so the character array typically remains in memory. To solve this issue, all character arrays are now explicitly copied with strcpy. This required modification of the conversion functions to free the character array memory before returning from fastnumbers. This resolves issue #2, and most likely resolves issue #1.
|
@Waateur I am pretty positive that I have just solved this issue with the most recent commit. By chance, was your input unicode? |
Hello,
I was using fastnumers.isfloat() to know is a string is a float or not. The string format was like "-0.353" most of the time. I used the function on a tons of data. I coud not spoted the string that made the segfault.
As there is a safe_float function I was wondering if this is normal or not.
Hopping this might help.
D.
The text was updated successfully, but these errors were encountered: