Avoid coercing nan or inf to int in fast_real. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a very large float was given to fast_real and coerce was set to True, then it would be blindly converted to an int even if the value was inf. This created an OverflowError which is not desirable. The solution is to explicitly check for inf and nan before attempting the integer conversion.
The tests make sure inf is returned instead of an OverflowError.
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 92.45% 92.47% +0.02%
==========================================
Files 17 17
Lines 848 851 +3
Branches 129 129
==========================================
+ Hits 784 787 +3
Misses 31 31
Partials 33 33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a very large float was given to fast_real and coerce was set to True,
then it would be blindly converted to an int even if the value was inf.
This created an OverflowError which is not desirable.
The solution is to explicitly check for inf and nan before attempting the
integer conversion.
This will fix #13.