Add ability to accept arbitrary int base. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No actual base implementation was performed.
This will allow fast_int to truly accept any argument that is valid for the built-in int. The work of actually converting from an arbitrary base is completely handled by the internal Python functions.
The isint function now accepts a base argument to determine if a string is a number in any arbitrary base.
|
Incorporated arbitrary base handling for int functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user wants to use fast_int to convert strings in binary, they should be able to do so.
This update adds the base option to fast_int and isint. It behaves in the same way
as the built-in int.