Remove Deprecated APIs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 99.51% 99.45% -0.07%
==========================================
Files 12 12
Lines 623 552 -71
==========================================
- Hits 620 549 -71
Misses 3 3
Continue to review full report at Codecov.
|
SethMMorton
force-pushed
the
remove-deprecated-apis
branch
from
c088ef4
to
fffb3f5
Compare
SethMMorton
force-pushed
the
remove-deprecated-apis
branch
from
fffb3f5
to
ed9b8b2
Compare
These are deprecated and no longer do anything.
These have been deprecated for quite some time.
Good riddance to bad rubbish. The existence of these functions is at best misleading.
SethMMorton
force-pushed
the
remove-deprecated-apis
branch
from
ed9b8b2
to
e0fa14b
Compare
These correspond to deprecated concepts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
natsortversion 6.0.0, several deprecated APIs will be removed.This Pull Request will be used as a way for me to highlight what is going to be removed so that objectors have a place to state their case.
Slated to be removed
number_typekeyword argumentsignedkeyword argumentexpkeyword argumentas_pathkeyword argumentpy3_safekeyword argumentTYPESAFEattribute of thensenumDIGITattribute of thensenumVERSIONattribute of thensenum (depending on the outcome of versorted should follow SemVer rules #61 - either way it will be changing)versortedfunction (depending on the outcome of versorted should follow SemVer rules #61 - either way it will be changing)index_versortedfunction (depending on the outcome of versorted should follow SemVer rules #61 - either way it will be changing)