Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Orders payed with GiftCard #29

Open
1 of 2 tasks
igormukhingmailcom opened this issue Nov 13, 2019 · 2 comments
Open
1 of 2 tasks

List of Orders payed with GiftCard #29

igormukhingmailcom opened this issue Nov 13, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@igormukhingmailcom
Copy link
Member

igormukhingmailcom commented Nov 13, 2019

If balances not equal (so gift card used) - ability to click on Used at orders link/button and see page with Orders list where this GiftCard was used.

  • For admin
  • For customer?
@igormukhingmailcom igormukhingmailcom added the enhancement New feature or request label Nov 13, 2019
@sahnhi
Copy link

sahnhi commented Dec 9, 2020

I'm trying to display the list of orders, but I have this error:
"Argument 1 passed to App\Repository\OrderRepository::createCompletedQueryBuilderByGiftCard() must be of the type string, object given"
It is an implementation error or a known error ?

Shoud I try to override this request to fix it ?

@igormukhingmailcom
Copy link
Member Author

Thanks for reporting, @sahnhi

e80c178#diff-b6158aa28c380775c04f4a5a6e2ceb57802addf71ca99777287cefa67de1d7e9L10

I guess we need

giftCardId: $id

rather than

giftCard: $id

This should fix the issue.

@sahnhi, don't you mind to try that and make PR if this fix will work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants