Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 0.11 branch compatible with Sylius 1.9 #173

Closed
wants to merge 4 commits into from

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Nov 16, 2021

Fixes #160

Merge this OR #172 but not both of them.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #173 (80b283f) into 0.11.x (072f481) will increase coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 80b283f differs from pull request most recent head b61de55. Consider uploading reports for the commit b61de55 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             0.11.x    #173      +/-   ##
===========================================
+ Coverage      9.51%   9.59%   +0.07%     
  Complexity      360     360              
===========================================
  Files            63      63              
  Lines          1166    1157       -9     
===========================================
  Hits            111     111              
+ Misses         1055    1046       -9     
Impacted Files Coverage Δ
src/Controller/Action/AddGiftCardToOrderAction.php 0.00% <0.00%> (ø)
src/Controller/Action/GiftCardBalanceAction.php 0.00% <0.00%> (ø)
src/Controller/Action/SearchGiftCardAction.php 0.00% <0.00%> (ø)
...endencyInjection/SetonoSyliusGiftCardExtension.php 70.00% <ø> (ø)
...istener/DefaultGiftCardConfigurationSubscriber.php 0.00% <ø> (ø)
src/Model/GiftCard.php 6.89% <ø> (ø)
src/Model/GiftCardConfiguration.php 0.00% <ø> (ø)
.../Provider/GiftCardChannelConfigurationProvider.php 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072f481...b61de55. Read the comment docs.

@Roshyo Roshyo mentioned this pull request Nov 16, 2021
@loevgaard
Copy link
Member

I think this PR can be closed?

@loevgaard loevgaard closed this Mar 3, 2022
@loevgaard loevgaard deleted the 0-11-sylius19-compat branch March 3, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't seem to install any version of this plugin in sylius 1.8 or 1.9
2 participants