Make actions compatible with newer Sylius versions #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.11.x #199 +/- ##
============================================
- Coverage 10.17% 10.06% -0.12%
- Complexity 353 358 +5
============================================
Files 62 62
Lines 1091 1103 +12
============================================
Hits 111 111
- Misses 980 992 +12
Continue to review full report at Codecov.
|
loevgaard
commented
Mar 3, 2022
composer.json
Outdated
| @@ -32,6 +31,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "doctrine/doctrine-bundle": "^1.2.13", | |||
| "friendsofsymfony/rest-bundle": "^2.8", | |||
There was a problem hiding this comment.
Maybe we should add ^2.8 || ^3.0 and then add it to require instead?
Roshyo
suggested changes
Mar 3, 2022
| ) { | ||
| private ?Environment $twig; | ||
|
|
||
| public function __construct(?ViewHandlerInterface $viewHandler, FormFactoryInterface $formFactory, Environment $twig = null) |
There was a problem hiding this comment.
put the arguments on 3 lines
Roshyo
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197