Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder for custom message input #217

Merged
merged 1 commit into from
May 6, 2022

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented May 6, 2022

Fixes #206

@Roshyo Roshyo requested a review from loevgaard May 6, 2022 05:07
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #217 (68d3fe9) into 0.12.x (dbff8f1) will not change coverage.
The diff coverage is n/a.

❗ Current head 68d3fe9 differs from pull request most recent head 02d4e33. Consider uploading reports for the commit 02d4e33 to get more accurate results

@@            Coverage Diff            @@
##             0.12.x     #217   +/-   ##
=========================================
  Coverage     49.73%   49.73%           
  Complexity      528      528           
=========================================
  Files           102      102           
  Lines          1687     1687           
=========================================
  Hits            839      839           
  Misses          848      848           
Impacted Files Coverage Δ
src/Form/Type/GiftCardType.php 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbff8f1...02d4e33. Read the comment docs.

@@ -19,6 +19,7 @@ setono_sylius_gift_card:
gift_card:
channel: Kanal
custom_message: Personlig besked
custom_message_placeholder: This message is printed on the gift card PDF...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
custom_message_placeholder: This message is printed on the gift card PDF...
custom_message_placeholder: Den her besked bliver udskrevet på gavekort-PDF'en...

@Roshyo Roshyo merged commit f1deed7 into 0.12.x May 6, 2022
@Roshyo Roshyo deleted the add-placeholder-custom-message branch May 6, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants