Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to delete old gift cards #229

Merged
merged 5 commits into from
May 13, 2022
Merged

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented May 13, 2022

Fixes #228

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #229 (5ad9f84) into 0.11.x (02d7eaf) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

❗ Current head 5ad9f84 differs from pull request most recent head 25841d2. Consider uploading reports for the commit 25841d2 to get more accurate results

@@             Coverage Diff             @@
##             0.11.x    #229      +/-   ##
===========================================
- Coverage     10.06%   9.54%   -0.52%     
- Complexity      358     375      +17     
===========================================
  Files            62      63       +1     
  Lines          1103    1163      +60     
===========================================
  Hits            111     111              
- Misses          992    1052      +60     
Impacted Files Coverage Δ
src/Command/Cli/DisableOldGiftCardsCommand.php 0.00% <0.00%> (ø)
src/Doctrine/ORM/GiftCardRepository.php 0.00% <0.00%> (ø)
src/SetonoSyliusGiftCardPlugin.php 0.00% <0.00%> (ø)
src/EmailManager/GiftCardEmailManager.php 0.00% <0.00%> (ø)
src/Form/Extension/ProductTypeExtension.php 0.00% <0.00%> (ø)
src/EventListener/GiftCardDeletionSubscriber.php 0.00% <0.00%> (ø)
...rc/Controller/Action/ResendGiftCardEmailAction.php 0.00% <0.00%> (ø)
...istener/DefaultGiftCardConfigurationSubscriber.php 0.00% <0.00%> (ø)
...ener/SendEmailWithGiftCardToCustomerSubscriber.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d7eaf...25841d2. Read the comment docs.

Add a limit to the search to avoid memory limit
@Roshyo Roshyo merged commit 2e89a15 into 0.11.x May 13, 2022
@Roshyo Roshyo deleted the delete-old-gc-command branch May 13, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a command to delete old gift cards
2 participants