Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the flush of order outside the applicator #244

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

loevgaard
Copy link
Member

Move the flush of order outside the applicator because flushes are handled by Doctrine middleware for Symfony messages

…ndled by Doctrine middleware for Symfony messages
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 41.60% // Head: 41.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e6550f5) compared to base (0d934ad).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head e6550f5 differs from pull request most recent head 258b1ad. Consider uploading reports for the commit 258b1ad to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             0.12.x     #244      +/-   ##
============================================
- Coverage     41.60%   41.58%   -0.02%     
  Complexity      590      590              
============================================
  Files           108      108              
  Lines          2103     2104       +1     
============================================
  Hits            875      875              
- Misses         1228     1229       +1     
Impacted Files Coverage Δ
src/Applicator/GiftCardApplicator.php 0.00% <ø> (ø)
src/Controller/Action/AddGiftCardToOrderAction.php 0.00% <0.00%> (ø)
...ontroller/Action/RemoveGiftCardFromOrderAction.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@loevgaard loevgaard merged commit 1f575d4 into 0.12.x Feb 27, 2023
@loevgaard loevgaard deleted the move-flush-outside-applicator branch February 27, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants