Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject soap client factory instead of an instance of SoapClient #12

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

loevgaard
Copy link
Member

This PR is a BC break.

Instead of injecting an instance of SoapClient into the Client we inject the SoapClientFactoryInterface. This has the advantage that the SoapClient doesn't have to be instantiated in order to instantiate the Client.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 76.63% // Head: 77.36% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (f15ac9c) compared to base (ab0346e).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f15ac9c differs from pull request most recent head 15bc3a7. Consider uploading reports for the commit 15bc3a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     76.63%   77.36%   +0.73%     
- Complexity       77       79       +2     
============================================
  Files            10       10              
  Lines           184      190       +6     
============================================
+ Hits            141      147       +6     
  Misses           43       43              
Impacted Files Coverage Δ
src/Client/Client.php 58.13% <100.00%> (+3.13%) ⬆️
src/Factory/SoapClientFactory.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@loevgaard loevgaard merged commit fa98d3a into master Oct 11, 2022
@loevgaard loevgaard deleted the abstract-soap-client branch October 11, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant