Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash related with 7TV animated pfp #87

Merged
merged 2 commits into from
May 4, 2022

Conversation

itzAlex
Copy link

@itzAlex itzAlex commented May 1, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This PR fixes a crash that occurs when you open someone's usercard and close it before the 7TV pfp is loaded. Closes #84

Copy link

@jupjohn jupjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change completely breaks animated profile pictures for me as shown by opening ALazyMeme's usercard on your branch:

image

I believe this fix only works on Windows (or whatever OS you're using) so I've suggested a change.

src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
Co-authored-by: James Upjohn <jammehcow@jammehcow.co.nz>
Copy link

@jupjohn jupjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TroyKomodo TroyKomodo merged commit 4d87db3 into SevenTV:chatterino7 May 4, 2022
@itzAlex itzAlex deleted the bugfix-7tv-pfp branch May 15, 2022 12:17
JAB-dev pushed a commit to JAB-dev/chatterino7WithDirtyFileUpload that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatterino keeps crashing
4 participants