Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write a proper README #96

Closed
nweldev opened this issue Oct 26, 2018 · 7 comments
Closed

write a proper README #96

nweldev opened this issue Oct 26, 2018 · 7 comments

Comments

@nweldev
Copy link
Contributor

nweldev commented Oct 26, 2018

For now, README.md is just the one generated by default by angular-cli. We should had informations about the course itself (slides link, timing, how to use the steps, etc...).

@geromegrignon
Copy link
Contributor

Do you want a french or english version?

@nweldev
Copy link
Contributor Author

nweldev commented Oct 30, 2018

I think a french one would be better given that we only give this in french, but not sure. I should check with @cbalit.

@geromegrignon
Copy link
Contributor

i thought so but given the issues are in english, i wanted to make sure!
I'll start a french template and translate it later on if required.

@nweldev
Copy link
Contributor Author

nweldev commented Oct 30, 2018

Yeah, maybe we should use french here too 😄 I'm just used to write everything in english on Github ...
Great idea thx!

@nweldev
Copy link
Contributor Author

nweldev commented Nov 10, 2018

Ok for a french version, but as their is some chance that this school may be given in english in a near futur, we'll keep issues and commits in english, and we'll also need an english versiion of this README later.

@geromegrignon
Copy link
Contributor

Pull request done.

@geromegrignon
Copy link
Contributor

Once the #93 will be completed, i'll consider adding a "Learning materials" section with links to additional content like :

  • ngrx.io
  • angular console
    ...

@nweldev nweldev closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants