Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(readme) write proper readme #97

Merged
merged 6 commits into from
Dec 17, 2018
Merged

feature(readme) write proper readme #97

merged 6 commits into from
Dec 17, 2018

Conversation

geromegrignon
Copy link
Contributor

deletes Angular CLI default Readme template
adds course presentation with image and link to SFEIR website
adds script commands
adds course projects
adds stack
adds course program

updates #96

@nweldev
Copy link
Contributor

nweldev commented Nov 13, 2018

Ouaw you really did a good work here, thx. I'll really read everything tomorrow though.
At first sight, I think we could maybe need to had some more informations about how to use the project itself (start, build, test, checkout, etc...).

@geromegrignon
Copy link
Contributor Author

Few bugs i need to fix :

  • several broken links because of a missing #
  • put "Calendrier ..." under the course logo
  • few typo corrections

I'll add a "Commandes utiles/ Useful Commands" section with script commands tomorrow.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Un TP :

* un projet par exercice :
`npm run client step01`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot --
npm run client -- hands-on
npm run client -- hands-on-solution

README.md Outdated

Ces commandes doivent être toutes suffixées par le nom du projet : `step01`

* `npm run ng build` - Compiles an Angular app into an output directory(dist)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot --

README.md Outdated



## Liste des projets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this section

geromegrignon and others added 6 commits December 17, 2018 15:56
deletes Angular CLI default Readme template
adds course presentation with image and link to SFEIR website
adds script commands
adds course projects
adds stack
adds course program

update #96
adds a useful commands section
fixes typo
change npm run client command from --project=step01 to step01
adds missing # to links

fixes #97
removes npm install -g @angular/cli
removes introduction
fixes SFEIR School line
removes course support link
removes script commands for steps
replaces ng by npm run ng for script commands

fixes#97
adds section : deroulement de la formation
removes section : planning de la formation

fixes #97
@nweldev nweldev merged commit 508bb83 into Sfeir:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants