-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Functionalities #75
base: master
Are you sure you want to change the base?
Conversation
parantak
commented
May 22, 2020
- Added preprocessing class, @someshsingh22 and @rajaswa , please check if this implementation would work.
- Added Optimal String Alignment (OSA) to Levenshtein, and made minor code changes to the original implementation
- Made minor documentation additions/changes.
It satisfies the triangle inequality, qualifies as a metric. 1. Introduces transposition edit cost 2. Not restricted by the assumption that every subsequence can only be edited once.
Update with Damerau-Levenshtein tests.
Different from Damerau-Levenshtein. This has a restrictive assumption.
minor documentation fix
See if this structure and then we can start implementing the filters
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 94.91% 95.00% +0.08%
==========================================
Files 8 10 +2
Lines 334 360 +26
==========================================
+ Hits 317 342 +25
- Misses 17 18 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preprocessing is perfect, but I don't know if OSA is used in literature because it is not a true metric
Also I would recommend to make PR from branches when you are making several changes, for example suppose we wish to continue with Preprocessing and not OSA you will have to roll back changes, these are completely parallel, so you can instead make two branches OSA and preprocessing and make separate PRs |
@someshsingh22 , I know it isn't a true metric, but then the thing is it captures a swap perfectly (in our case the swap perturbation), without allowing that subsequence to be edited any further, which is why I included it an option in Levenshtein itself, and not as a separate metric. |