-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added base class #26
added base class #26
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 8 +3
Lines 95 156 +61
=====================================
- Misses 95 156 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@akagam1 thanks for the PR! I have left some comments. Also, do run the pre-commit before pushing so that lint issues are resolved |
@akagam1 **/.DS_Store |
Additionally, @akagam1 the DS store file still shows up in your commit |
Co-authored-by: Abhijit Deo <72816663+abhi-glitchhg@users.noreply.github.com>
@akagam1 please make the final changes. I'll merge after that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @akagam1; changes look good to me;
The datatypes for other arguments might need to be modified in the future, but for now, I'm okay with those.
No description provided.