Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added base class #26

Merged
merged 10 commits into from
Aug 22, 2022
Merged

added base class #26

merged 10 commits into from
Aug 22, 2022

Conversation

akagam1
Copy link
Contributor

@akagam1 akagam1 commented Jul 23, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #26 (891e970) into main (d136a70) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main     #26   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5       8    +3     
  Lines         95     156   +61     
=====================================
- Misses        95     156   +61     
Impacted Files Coverage Δ
jeta/base.py 0.00% <0.00%> (ø)
jeta/data/base_dataset.py 0.00% <0.00%> (ø)
jeta/data/task_dataset.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jeta/base.py Outdated Show resolved Hide resolved
jeta/base.py Outdated Show resolved Hide resolved
jeta/base.py Outdated Show resolved Hide resolved
jeta/base.py Outdated Show resolved Hide resolved
jeta/base.py Outdated Show resolved Hide resolved
@veds12
Copy link
Member

veds12 commented Jul 23, 2022

@akagam1 thanks for the PR! I have left some comments. Also, do run the pre-commit before pushing so that lint issues are resolved

@akagam1 akagam1 marked this pull request as ready for review July 27, 2022 08:42
@abhi-glitchhg
Copy link
Member

@akagam1
I think you can delete the .DS_Store files in this PR,
.DS_Store need not be tracked by git. You can add the below line in the .gitignore file so that git will ignore all such files in the future.

**/.DS_Store

jeta/base.py Outdated Show resolved Hide resolved
jeta/base.py Outdated Show resolved Hide resolved
jeta/base.py Outdated Show resolved Hide resolved
@veds12
Copy link
Member

veds12 commented Aug 8, 2022

Additionally, @akagam1 the DS store file still shows up in your commit

@abhi-glitchhg abhi-glitchhg linked an issue Aug 8, 2022 that may be closed by this pull request
jeta/base.py Outdated Show resolved Hide resolved
Co-authored-by: Abhijit Deo <72816663+abhi-glitchhg@users.noreply.github.com>
@veds12
Copy link
Member

veds12 commented Aug 21, 2022

@akagam1 please make the final changes. I'll merge after that

Copy link
Member

@abhi-glitchhg abhi-glitchhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @akagam1; changes look good to me;

The datatypes for other arguments might need to be modified in the future, but for now, I'm okay with those.

jeta/base.py Outdated Show resolved Hide resolved
@veds12 veds12 merged commit e05147f into SforAiDl:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a base class for the algorithms
4 participants