Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default icon #180

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Update default icon #180

merged 2 commits into from
Mar 7, 2024

Conversation

chelming
Copy link
Contributor

@chelming chelming commented Mar 7, 2024

The home-assistant icon has not been updated and is scheduled to be removed. Sending an invalid icon will cause the app to use the default icon. home-assistant/android#4252

closes #148

The home-assistant icon has not been updated and is scheduled to be removed. Sending an invalid icon will cause the app to use the default icon. home-assistant/android#4252

closes SgtBatten#148
@SgtBatten
Copy link
Owner

Thank you.

To avoid confusing people who might be expecting the frigate icon can we simply remove the space to make it invalid "homeassistant" or use "home-ass" or something rather than frigate. Ready to approve once you respond. Appreciate it.

@chelming
Copy link
Contributor Author

chelming commented Mar 7, 2024

yeah. that works. 👍 updated

Copy link
Owner

@SgtBatten SgtBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SgtBatten SgtBatten merged commit 87e611a into SgtBatten:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Doesn't use new home assistant icon
2 participants