Change camera name to lowercase in api call #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gerdna sorry i missed this. is this working for you? |
|
@SgtBatten No problem. Yes it works perfectly for me. |
|
closes #47 |
SgtBatten
added a commit
that referenced
this pull request
Aug 19, 2023
* 0.12.0.1a (#20) * 0.12.0.1a * Update critical functionality on android to align it with android * be aware it will now bypass phones silent/vibrate mode * Android notifications will always have ttl: 0 and priority: high so no need for critical for this purpose anymore * clarify color input does not work on IOS * Reworded Sticky description * Added all example URLs to all Action Buttons. * Improve critical function Critical template can handle event details now. including updated info. * Update Beta Add Video (gif) option to Android (for now) Automatically strip _1, 2 or 3 from camera entity Add top score example to critical notifications selector * Add initial delay option (#33) Use the initial delay if you do not use "update image" and are experiencing notifications without any attachment. Also some cleanup as HA core has resolved #9 * Create Guide: Debug Option.md * Typo fix (#35) * fix: typo * fix: typo again * IOS Live view entity selector (#42) * IOS Live view entity selector Live view now supports any camera entity that is selected. * Add steel blue colour as default (#37) * Add steel blue colour as default * Add steel blue colour as default * Update Beta (#44) Add IOS video functionality Reduce delay for video to 5 seconds post event Add IOS Action button Icon options You can now choose which entity is used for IOS live view Add subtitle option Added new message presets containing the time Fixed some small typos. * standardise entered_zones variable * iOS url debugging * Fix video input title. * Change camera name to lowercase in api call (#40) * change proxy stream to lowercase camera name --------- Co-authored-by: SgtBatten <sgt@batten.net.au> * Update colors to use hex values (#49) * Update colors to use hex values Based on HA style https://github.com/home-assistant/frontend/blob/983bba357a421bf09b950bcdacfc37f416123839/src/resources/ha-style.ts * Fix long message * replace hyphens in view stream * fix typo iOS (#65) * Update README.md fix typo iOS * Update Stable fix typo iOS * Update Beta fix typo iOS * utilise regex instead of rstrip (#70) * Add Android Auto close #60 * Clarify Android TV requirments. Requested in #66 * Regex escape fix * Fix debug variables Remove client ID from looped image key in debug. It's only in beta * Add base url to iOS image in groups --------- Co-authored-by: Brian Steere <dianoga7@3dgo.net> Co-authored-by: Andre <61070279+Gerdna@users.noreply.github.com> Co-authored-by: Fredrick-III <66221093+Fredrick-III@users.noreply.github.com> Co-authored-by: chpego <38792705+chpego@users.noreply.github.com>
SgtBatten
added a commit
that referenced
this pull request
Aug 19, 2023
* 0.12.0.1a (#20) * 0.12.0.1a * Update critical functionality on android to align it with android * be aware it will now bypass phones silent/vibrate mode * Android notifications will always have ttl: 0 and priority: high so no need for critical for this purpose anymore * clarify color input does not work on IOS * Reworded Sticky description * Added all example URLs to all Action Buttons. * Improve critical function Critical template can handle event details now. including updated info. * Update Beta Add Video (gif) option to Android (for now) Automatically strip _1, 2 or 3 from camera entity Add top score example to critical notifications selector * Add initial delay option (#33) Use the initial delay if you do not use "update image" and are experiencing notifications without any attachment. Also some cleanup as HA core has resolved #9 * Create Guide: Debug Option.md * Typo fix (#35) * fix: typo * fix: typo again * IOS Live view entity selector (#42) * IOS Live view entity selector Live view now supports any camera entity that is selected. * Add steel blue colour as default (#37) * Add steel blue colour as default * Add steel blue colour as default * Update Beta (#44) Add IOS video functionality Reduce delay for video to 5 seconds post event Add IOS Action button Icon options You can now choose which entity is used for IOS live view Add subtitle option Added new message presets containing the time Fixed some small typos. * standardise entered_zones variable * iOS url debugging * Fix video input title. * Change camera name to lowercase in api call (#40) * change proxy stream to lowercase camera name --------- Co-authored-by: SgtBatten <sgt@batten.net.au> * Update colors to use hex values (#49) * Update colors to use hex values Based on HA style https://github.com/home-assistant/frontend/blob/983bba357a421bf09b950bcdacfc37f416123839/src/resources/ha-style.ts * Fix long message * replace hyphens in view stream * fix typo iOS (#65) * Update README.md fix typo iOS * Update Stable fix typo iOS * Update Beta fix typo iOS * utilise regex instead of rstrip (#70) * Add Android Auto close #60 * Clarify Android TV requirments. Requested in #66 * Regex escape fix * Fix debug variables Remove client ID from looped image key in debug. It's only in beta * Add base url to iOS image in groups --------- Co-authored-by: Brian Steere <dianoga7@3dgo.net> Co-authored-by: Andre <61070279+Gerdna@users.noreply.github.com> Co-authored-by: Fredrick-III <66221093+Fredrick-III@users.noreply.github.com> Co-authored-by: chpego <38792705+chpego@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the issue that the View Stream action did not worked. I only got an "Not found" as a result. After some investigation, I recognized that I named the Camera with a captial letter ("Driveway") in Frigate. It seems like the API can only handle lowercase camera names.
But maybe it is not a good idea to have the camera named with a capital letter in the beginning. Please let me know if I should rather change my camera name ;).