Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to be able to build with Xcode 15 #29

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

faisal
Copy link

@faisal faisal commented Oct 26, 2023

A number of changes in support of being able to build with the current Xcode:

  • Set all targets' build version, marketing version, and swift version to inherit from the project. With the minimum deployment target of 10.15 and use of Swift 5, Xcode no longer bundles Swift libraries in the built app for backwards compatibility, which cuts the resulting app size by ~90%.
  • Stopped manually embedding the Clean_Links entitlement

@faisal
Copy link
Author

faisal commented Oct 26, 2023

This is largely ready, but it builds on #28 and we should wait for that to land before landing this one.

@faisal faisal mentioned this pull request Oct 26, 2023
Have all targets use the project's macOS deployment target, bundle version, and Swift version. This restores the ability to build using Xcode 15, shrinks the package size substantially (since we no longer need to bundle the Swift libraries in the app), and should make it easier to allow future development since we no longer need to chase down target setting mismatches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant