Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long-press hotkey(s) #352

Open
bhajneet opened this issue Jan 8, 2020 · 7 comments
Open

Add long-press hotkey(s) #352

bhajneet opened this issue Jan 8, 2020 · 7 comments
Assignees
Labels
Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Few Does not affect many end-users. Scope: Frontend/Controller □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

bhajneet commented Jan 8, 2020

"Long" as over 300ms (proposal to test).

Key Single Hold GUI
Spacebar Autoselect Set current line to "Main" Hold "Autoselect" icon. Or add a right-click context menu for autoselect with more options, one of which is "set current line to main".
Enter Activate Right Click Mouse right click
Ctrl+y Go to History activity Go to first non-current result of history activity Hold "history" icon / right click history icon (not sure how this works in v3)
Next line on last line Nothing Go to next shabad Click "Next shabad" pseudo entry #177
Esc Use default cleared screen Open context menu/right click esc icon #392 Long-press/Right click esc icon
Ctrl+/ Go to search activity, highlight query in search activity Switch input #394 Click button on leftside of search bar

More ideas, for discussion:

  • Holding ctrl+c (which should not be the hotkey for navigator btw), should allow customization of copying, so ctrl+c held + 1 would perhaps copy only gurbani. Might be better to always show copy context menu on single press too.
@bhajneet bhajneet added Impacts Most Affects a majority of end-users. Status: In Research □ Type Story Feature or requirement written from the user's perspective using non-technical language. Scope: Frontend/Controller labels Jan 8, 2020
@bhajneet
Copy link
Member Author

These need animations/way for the user to understand what holding the hotkey does before it activates

In the example of holding the key down, right, l, or left-click on the last line of a shabad should start to fill up some progress bar of sorts saying "next shabad" or such which when filled activates the long-press hotkey. In the UI with an unhidden controller it could be a new "line" after the last one which slides up and says "Next shabad" and fills up for whatever amount of time we set for long-press hotkeys (I'm going to suggest half a second for now, but definitely something over 300ms)

@bhajneet
Copy link
Member Author

I'd also like to see "holding" of down, right, or l in an open controller for navigator scroll down the list of lines without actually activating any of them. The viewport would be scrolling, and whatever line is closest to the middle would be highlighting/activating at the end.

When we have #237 we can make it so long pressing the scrolling of the viewport will switch to a pseudo-selector / non-activated one which requires enter to actually display.

Long press would also close #177

@Harjot1Singh
Copy link
Member

I think #177 is still useful for mobile environments, no?

@bhajneet
Copy link
Member Author

True, and and probably the same use case for GUI only users/mouse only users.

Perhaps we can have the next shabad always visible but also activatable by long press on the line before it.

@Harjot1Singh
Copy link
Member

Another general question/thought I have: long-press hotkeys, or most hotkeys for that matter should be accessible through the GUI, given that they're meant to be shortcuts. So it's worth thinking about how we can replicate these behaviours. Perhaps holding down the history icon is what holding ctrl-y maps to

@bhajneet
Copy link
Member Author

bhajneet commented Feb 6, 2020

Yeah that's a good point re: GUI

I've updated the original table

I also think there should be some way to "see" the hold happening. So some progress bar, or circle circumference that fills up clockwise, etc.

@Harjot1Singh Harjot1Singh added the Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. label Feb 27, 2020
@bhajneet bhajneet added Impacts Few Does not affect many end-users. and removed Impacts Most Affects a majority of end-users. labels Mar 7, 2020
@bhajneet
Copy link
Member Author

Depends on #394 and #462 / #154 for further evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Few Does not affect many end-users. Scope: Frontend/Controller □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
Status: Triage
Development

No branches or pull requests

2 participants