How do i fix the Head Icons of my Custom Healthbar?

[Ramiro0045]

Describe your problem here.

Basically, im trying to port my mod that was made in 0.6.3 to 0.7.1h
but the healthbar changed a lot code wise, which made it so im unable to fix the head icons
or at least use updateHitbox('healthBar'); to fix it

so, how do i fix it in psych engine 0.7.1h?

this is how my HealthBar Script in lua looks like

-- Originally Made by Misha21220
-- Edited by ItzJiggzy

-- It Only "works" in Psych Engine 0.7.X

function onCreate()
	if getPropertyFromClass('backend.ClientPrefs', 'data.zerothCustomHealthbar') and not hideHud then
		customHealthBar_Border()
		customHealthBar_Stats()
	end
end

function onCreatePost()
	if getPropertyFromClass('backend.ClientPrefs', 'data.zerothCustomHealthbar') and not hideHud then
		customHealthBar_FlxBar()
		-- customHealthBar_Icons()
	end
end

function customHealthBar_Border()
-- Border
	makeLuaSprite('HealthBarBorder', 'ZerothBarBorderAlt')
	setObjectCamera('HealthBarBorder', 'hud')
	setProperty('HealthBarBorder.alpha', getPropertyFromClass('backend.ClientPrefs', 'data.healthBarAlpha'))
	scaleLuaSprite('HealthBarBorder', 0.8, 0.8)
	screenCenter('HealthBarBorder', 'x')
	setProperty('HealthBarBorder.y', getProperty('healthBar.y') - 108)
	addLuaSprite('HealthBarBorder', true)
	
	-- if downscroll then
		-- setProperty('HealthBarBorder.y', getProperty('healthBar.y') - 66)
		-- setProperty('HealthBarBorder.flipY', true)
	-- end
end

function customHealthBar_Stats()
-- Stats
	makeLuaSprite('HealthBarStats', 'ZerothBarStats')
	setObjectCamera('HealthBarStats', 'hud')
	setProperty('HealthBarStats.alpha', getPropertyFromClass('backend.ClientPrefs', 'data.healthBarAlpha'))
	scaleLuaSprite('HealthBarStats', 0.8, 0.7)
	screenCenter('HealthBarStats', 'x')
	setProperty('HealthBarStats.y', getProperty('healthBar.y') + 25)
	addLuaSprite('HealthBarStats', true)
	-- if downscroll then
		-- setProperty('HealthBarStats.y', getProperty('healthBar.y') + 43)
	-- end
end

function customHealthBar_FlxBar()
local centeredFlxBar = 204 - (getProperty('healthBar.width') / 2)
-- flxBar -- Needs Fixing
	scaleObject('healthBar', 1.45, 4.3)
	-- screenCenter('healthBar', 'x')
	setProperty('healthBar.y', getProperty('healthBar.y') - 45)
	setProperty('healthBar.x', centeredFlxBar);
	-- updateHitbox('healthBar');
end

-- Dont know why i felt proud/satisfied on like this thingy, when it basically others guy code but with my textures

and also, this are the Textures that is using, even tho they are not connected to the actions of the flxBar or the Head Icons

HealthBarBorder:

HealthBarStats:

Are you modding a build from source or with Lua?

Lua

What is your build target?

Windows x64

Did you edit anything in this build? If so, mention or summarize your changes.

Yes, I edited a ClientPrefs.hx to add custom options and Playstate.hx to change the healthbarImage without affectting the original healthbar, also Achievements but that doesnt have anything to do with this issue, i didnt change anything on HealthIcon.hx or any of the maths related to the Healthbar or the Head Icons

[BernardoGP4504]

Update healthBar.barCenter accordingly, the default is set to 637.5

[BernardoGP4504]

Also to make that if statement be better, do this instead:

if (ClientPrefs.data.zerothCustomHealthbar)
{
    healthBar = new Bar(0, FlxG.height * (!ClientPrefs.data.downScroll ? 0.89 : 0.11), 'healthBarBlank', function() return health, 0, 2);
}
else
{
    healthBar = new Bar(0, FlxG.height * (!ClientPrefs.data.downScroll ? 0.89 : 0.11), 'healthBar', function() return health, 0, 2);
    healthBar.screenCenter(X);
}
healthBar.leftToRight = false;
healthBar.scrollFactor.set();
healthBar.visible = !ClientPrefs.data.hideHud;
healthBar.alpha = ClientPrefs.data.healthBarAlpha;
reloadHealthBarColors();
uiGroup.add(healthBar);

Since both statements, after creating the bar do the same code

[Ramiro0045]

they have a very similar code bcs i dont understand how to make the bar larger and thiccer
so it was a bit more of a placeholder until i was able to figure out how to make it like how i wanted in source

maybe healthbar.barCenter actually does what i wanted to do but i was never able to make it work in lua
it didnt change anything if it was setProperty('healthBar.barCenter', 1000) or setProperty('barCenter', 1000) or setProperty('healthBar.barCenter.x', 1000) or setProperty('barCenter.x', 1000), so idk

maybe it was a setPropertyFromClass or setPropertyFromGroup thing but idk

[BernardoGP4504]

they have a very similar code bcs i dont understand how to make the bar larger and thiccer so it was a bit more of a placeholder until i was able to figure out how to make it like how i wanted in source

maybe healthbar.barCenter actually does what i wanted to do but i was never able to make it work in lua it didnt change anything if it was setProperty('healthBar.barCenter', 1000) or setProperty('barCenter', 1000) or setProperty('healthBar.barCenter.x', 1000) or setProperty('barCenter.x', 1000), so idk

maybe it was a setPropertyFromClass or setPropertyFromGroup thing but idk

It is infact setProperty('healthBar.barCenter', 637.5) or any value you might want, but the only way I did change the variable is by using it on update, which made the icons not wanna move

You might wanna try doing it in onCreatePost, but I would recommend doing it in source instead by just putting

healthBar.barCenter = 613.5;

right after creating the healthBar

[Ramiro0045]

It did worked on onUpdate but it only moved the heads
but when the health gets updated, it moves the heads for one frame and goes back to the same static position

[BernardoGP4504]

It did worked on onUpdate but it only moved the heads but when the health gets updated, it moves the heads for one frame and goes back to the same static position

Ik, I've said that. I'm trying to see if I can solve this in Lua on my own. Keep testing until you can solve it or until I finish the script.

[Ramiro0045]

I didnt fully read your response but i think it will move how much the heads is than the actual healthbar size
but you could tell me how the bar is generated

like what this means exactly:

healthBar = new Bar(0, FlxG.height * (!ClientPrefs.data.downScroll ? 0.89 : 0.11), 'healthBar', function() return health, 0, 2);

especially in the part that says about downScroll and function() return health
bcs in downScroll, idk what the ? and the : means, i think it is a if else statement but in one line but im not entirely sure

[BernardoGP4504]

I didnt fully read your response but i think it will move how much the heads is than the actual healthbar size but you could tell me how the bar is generated like what this means exactly: healthBar = new Bar(0, FlxG.height * (!ClientPrefs.data.downScroll ? 0.89 : 0.11), 'healthBar', function() return health, 0, 2); especially in the part that says about downScroll and function() return health bcs in downScroll, idk what the ? and the : means, i think it is a if else statement but in one line but im not entirely sure

The variable that's breaking the icons is the `barCenter` thing. Don't remove it though, as It's crucial. Also there's a better way to do that Lua script, using `runHaxeCode`; Where as of 0.7, you can use `loadGraphic` on each part of the healthBar.

…

[Ramiro0045]

i mean...
i did make some workaround using graphics, but i was asking it was possible with the original flxBar

-- Originally Made by Misha21220
-- Edited by ItzJiggzy

-- It Only works in Psych Engine 0.7.X

local function to_hex(rgb)
    return string.format("%x", (rgb[1] * 0x10000) + (rgb[2] * 0x100) + rgb[3])
end

function onCreatePost()
	if getPropertyFromClass('backend.ClientPrefs', 'data.zerothCustomHealthbar') and not hideHud then
	-- Adding New Sprites and Configuration
		-- Border
			makeLuaSprite('HealthBarBorder', 'ZerothBarBorderAlt')
			setObjectCamera('HealthBarBorder', 'hud')
			setProperty('HealthBarBorder.alpha', getPropertyFromClass('backend.ClientPrefs', 'data.healthBarAlpha'))
			scaleLuaSprite('HealthBarBorder', 0.8, 0.8)
			screenCenter('HealthBarBorder', 'x')
			setProperty('HealthBarBorder.y', getProperty('healthBar.y') - 108)
			addLuaSprite('HealthBarBorder', true)
		
		-- Stats
			makeLuaSprite('HealthBarStats', 'ZerothBarStats')
			setObjectCamera('HealthBarStats', 'hud')
			setProperty('HealthBarStats.alpha', getPropertyFromClass('backend.ClientPrefs', 'data.healthBarAlpha'))
			scaleLuaSprite('HealthBarStats', 0.8, 0.7)
			screenCenter('HealthBarStats', 'x')
			setProperty('HealthBarStats.y', getProperty('healthBar.y') + 25)
			addLuaSprite('HealthBarStats', true)

		-- Enemy HP
			makeLuaSprite('EnemyHP', 'DAD_HP_BAR', 0, 0)
			makeGraphic('EnemyHP', 425, 45, 'FFFFFF')
			setObjectCamera('EnemyHP', 'hud')
			screenCenter('EnemyHP', 'x')
			setProperty('EnemyHP.origin.x', 425)
			setProperty('EnemyHP.y', getProperty('healthBar.y') - 20)
			setProperty('EnemyHP.alpha', 1)
			setProperty('EnemyHP.color', getColorFromHex(to_hex(getProperty("dad.healthColorArray"))))
			addLuaSprite('EnemyHP', false)

		-- Player HP
			makeLuaSprite('PlayerHP', 'BF_HP_BAR', 0, 0)
			makeGraphic('PlayerHP', 850, 45, 'FFFFFF')
			setObjectCamera('PlayerHP', 'hud')
			screenCenter('PlayerHP', 'x')
			setProperty('PlayerHP.y', getProperty('healthBar.y') - 20)
			setProperty('PlayerHP.alpha', 1)
			setProperty('PlayerHP.color', getColorFromHex(to_hex(getProperty("boyfriend.healthColorArray"))))
			addLuaSprite('PlayerHP', false)

		-- Original flxBar
			screenCenter('healthBar', 'x')
			-- setProperty('healthBar.scale.x', 1.45) -- This is Invalidated if barWidth or barOffset is changed
			setProperty('healthBar.barWidth', 850)
			setProperty('healthBar.barOffset.x', -125)
			setProperty('healthBar.alpha', 0)
	end
end

function onUpdate()
	setProperty('EnemyHP.scale.x', 2 - getProperty('health'))
	setProperty('EnemyHP.x', getProperty('healthBar.barCenter') - 425)
end

-- Dont know why i felt proud/satisfied on like this thingy, when it basically others guy code but with my textures
-- Hopefully in the future i could make the flxbar actually like work the way i wanted to be, but for now i like it like this.

This two did change the heads position but it didnt change the size of the bar
setProperty('healthBar.barWidth', 850)
setProperty('healthBar.barOffset.x', -125)

is like their heads follow a invisible bounds that is not related to the Bar itself but somehow it is?

[BernardoGP4504]

Not only I've fixed the issue, I've made a better Lua script.

Just do:

function onUpdatePost()
    setProperty('iconP1.offset.x', -296)
    setProperty('iconP2.offset.x', -298)
end

[BernardoGP4504]

healthbar.lua

Here's the fix in source code.

if (ClientPrefs.data.zerothCustomHealthbar)
{
    healthBar = new Bar(0, FlxG.height * (!ClientPrefs.data.downScroll ? 0.89 : 0.11), 'healthBarBlank', function() return health, 0, 2);
    healthBar.bg.y -= (!ClientPrefs.data.downScroll ? 142 : 108);
    healthBar.bg.scale.set(0.8, 0.8);

    if (!ClientPrefs.data.downScroll)
        scoreTxt.y -= 20;
    else
        scoreTxt.y += 17;
}
else
{
    healthBar = new Bar(0, FlxG.height * (!ClientPrefs.data.downScroll ? 0.89 : 0.11), 'healthBar', function() return health, 0, 2);
    healthBar.screenCenter(X);
}
healthBar.leftToRight = false;
healthBar.scrollFactor.set();
healthBar.visible = !ClientPrefs.data.hideHud;
healthBar.alpha = ClientPrefs.data.healthBarAlpha;
reloadHealthBarColors();
uiGroup.add(healthBar);

On the updatePost function, put this there

if (ClientPrefs.data.zerothCustomHealthbar)
{
    iconP1.offset.x = -296;
    iconP2.offset.x = -298;
    for (ico in [iconP1, iconP2])
    {
        if (!ClientPrefs.data.downScroll)
            ico.offset.y = 27;
        else
            ico.offset.y = -7;
    }
}

[Ramiro0045]

also, removing the screenCenter part was also a placeholder
idk what i was thinking when i removed that

also, in what version did you run that healthbar.lua, bcs is not really working at all
i heard somewhere that runHaxeCode and other hscript stuff was broken
im using v0.7.1h experimental

[BernardoGP4504]

I'm using 0.7.1h Release, but how did it break? Send in a screenshot

[Ramiro0045]

is just not running at all, thats it
no errors or crashes, just not executing the code