Fix #218. Prevent spamming SetMovementSettings on movement component …

…by turning the call into event based.
ShadowfallStudios · May 19, 2021 · 89f3363 · 89f3363
1 parent 5eb4d3a
commit 89f3363
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Source/ALSV4_CPP/Private/Character/ALSBaseCharacter.cpp b/Source/ALSV4_CPP/Private/Character/ALSBaseCharacter.cpp
@@ -154,6 +154,8 @@ void AALSBaseCharacter::BeginPlay()
 		MainAnimInstance->SetRootMotionMode(ERootMotionMode::IgnoreRootMotion);
 	}
 
+	MyCharacterMovementComponent->SetMovementSettings(GetTargetMovementSettings());
+
 	DebugComponent = FindComponentByClass<UALSDebugComponent>();
 }
 
@@ -877,6 +879,8 @@ void AALSBaseCharacter::OnStanceChanged(const EALSStance PreviousStance)
 	{
 		CameraBehavior->Stance = Stance;
 	}
+
+	MyCharacterMovementComponent->SetMovementSettings(GetTargetMovementSettings());
 }
 
 void AALSBaseCharacter::OnRotationModeChanged(EALSRotationMode PreviousRotationMode)
@@ -893,6 +897,8 @@ void AALSBaseCharacter::OnRotationModeChanged(EALSRotationMode PreviousRotationM
 	{
 		CameraBehavior->SetRotationMode(RotationMode);
 	}
+
+	MyCharacterMovementComponent->SetMovementSettings(GetTargetMovementSettings());
 }
 
 void AALSBaseCharacter::OnGaitChanged(const EALSGait PreviousGait)
@@ -1074,9 +1080,6 @@ void AALSBaseCharacter::UpdateCharacterMovement()
 		SetGait(ActualGait);
 	}
 
-	// Get the Current Movement Settings and pass it through to the movement component.
-	MyCharacterMovementComponent->SetMovementSettings(GetTargetMovementSettings());
-
 	// Update the Character Max Walk Speed to the configured speeds based on the currently Allowed Gait.
 	MyCharacterMovementComponent->SetAllowedGait(AllowedGait);
 }

diff --git a/Source/ALSV4_CPP/Private/Character/ALSCharacterMovementComponent.cpp b/Source/ALSV4_CPP/Private/Character/ALSCharacterMovementComponent.cpp
@@ -183,6 +183,7 @@ void UALSCharacterMovementComponent::SetMovementSettings(FALSMovementSettings Ne
 {
 	// Set the current movement settings from the owner
 	CurrentMovementSettings = NewMovementSettings;
+	bRequestMovementSettingsChange = true;
 }
 
 void UALSCharacterMovementComponent::SetAllowedGait(EALSGait NewAllowedGait)