Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UALSMathLibrary::FixDiagonalGamepadValues wrongly named parameters #113

Closed
Drakynfly opened this issue Feb 2, 2021 · 0 comments
Closed
Labels
bug Something isn't working in progress

Comments

@Drakynfly
Copy link
Contributor

After a particularly confusing couple hours trying to debug a specific issue in my fork, I discovered that UALSMathLibrary::FixDiagonalGamepadValues has the two parameters named backwards. The function declares them in the order (Y, Z) but every call to them passes variables in the order (Z, Y), and the function's implementation uses them backwards.
Although its makes no difference other than for readability, it would be nice to have them named correctly.

@dyanikoglu dyanikoglu added bug Something isn't working in progress labels Feb 4, 2021
dyanikoglu added a commit that referenced this issue Feb 17, 2021
Chris-Baker pushed a commit to Chris-Baker/ALSV4_CPP that referenced this issue Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress
Projects
None yet
Development

No branches or pull requests

2 participants