Mantle with velocity #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-exiin
added a commit
to seb-exiin/ALSV4_CPP
that referenced
this pull request
Nov 15, 2020
|
It looks good, but before merging it, I need to extensively test the PR to make sure everything is working as expected. |
seb-exiin
commented
Nov 16, 2020
| if (MantleLedgeLS.Component != nullptr && !IsComponentVelocityValid(MantleLedgeLS.Component, AcceptableVelocityWhileMantling)) | ||
| { | ||
| //The surface to mantle moves too fast | ||
| MantleEnd(); |
There was a problem hiding this comment.
This line is a fallback, might not be the best way of doing it
There was a problem hiding this comment.
I'm going to merge this PR as just to check velocity on beginning of the mantle, but not during mantle action. Ending mantle during animation may cause issues.
dyanikoglu
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify if the velocity is not to high on objects for mantling
see the difference:
https://youtu.be/9Q52tIWwDlo