Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UpdateChecker.java #1403

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Update UpdateChecker.java #1403

merged 2 commits into from
Dec 8, 2023

Conversation

MustafaAgamy
Copy link
Contributor

UpdateEngineCheck

UpdateEngineCheck
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4257b7e) 46.74% compared to head (71cf856) 42.68%.
Report is 2 commits behind head on main.

Files Patch % Lines
...va/com/shaft/listeners/internal/UpdateChecker.java 68.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1403      +/-   ##
============================================
- Coverage     46.74%   42.68%   -4.07%     
+ Complexity     1200     1132      -68     
============================================
  Files           106      106              
  Lines         10280    10288       +8     
  Branches       1069     1070       +1     
============================================
- Hits           4805     4391     -414     
- Misses         4873     5336     +463     
+ Partials        602      561      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MohabMohie MohabMohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you very much for implementing this. It'll be a great help for our current and future users.

I think it's worth a blog post.

@MohabMohie MohabMohie merged commit 148fa3a into main Dec 8, 2023
21 of 23 checks passed
@MohabMohie MohabMohie deleted the UpdateCheckEngine branch December 8, 2023 22:25
@MustafaAgamy MustafaAgamy linked an issue Dec 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: SHAFT_ENGINE Daily Update Check code
2 participants