Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixAllureAttachements #1422

Merged
merged 5 commits into from
Dec 14, 2023
Merged

FixAllureAttachements #1422

merged 5 commits into from
Dec 14, 2023

Conversation

MustafaAgamy
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (54ab832) 47.79% compared to head (6fa6354) 15.28%.
Report is 3 commits behind head on main.

Files Patch % Lines
.../main/java/com/shaft/listeners/AllureListener.java 0.00% 49 Missing ⚠️
...shaft/listeners/internal/TestNGListenerHelper.java 25.58% 29 Missing and 3 partials ⚠️
.../main/java/com/shaft/listeners/TestNGListener.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1422       +/-   ##
=============================================
- Coverage     47.79%   15.28%   -32.52%     
+ Complexity     1198      386      -812     
=============================================
  Files           105      106        +1     
  Lines         10147    10222       +75     
  Branches       1049     1049               
=============================================
- Hits           4850     1562     -3288     
- Misses         4687     8378     +3691     
+ Partials        610      282      -328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MustafaAgamy MustafaAgamy self-assigned this Dec 14, 2023
Copy link
Contributor

@MohabMohie MohabMohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for finally solving this!!!

@MohabMohie
Copy link
Contributor

closes #1043

@MohabMohie MohabMohie merged commit a83cf64 into main Dec 14, 2023
6 of 22 checks passed
@MohabMohie MohabMohie deleted the AllureAttachements branch December 14, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: implement this workaround for allure attachments
2 participants