Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshots on chrome for mac #1426

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

MohabMohie
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (1af2c4a) 50.48% compared to head (aeab49c) 50.67%.

Files Patch % Lines
...com/shaft/driver/internal/DriverFactoryHelper.java 19.51% 19 Missing and 14 partials ⚠️
.../main/java/com/shaft/listeners/TestNGListener.java 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1426      +/-   ##
============================================
+ Coverage     50.48%   50.67%   +0.19%     
- Complexity     1284     1288       +4     
============================================
  Files           106      106              
  Lines         10239    10212      -27     
  Branches       1055     1041      -14     
============================================
+ Hits           5169     5175       +6     
+ Misses         4428     4398      -30     
+ Partials        642      639       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- stop logging elapsed time except for debugMode
- remove debugMode from MacOSX_Chrome_Local job after fixing it
@MohabMohie MohabMohie merged commit a2f1faf into main Dec 19, 2023
25 of 26 checks passed
@MohabMohie MohabMohie deleted the fix-screenshots-on-chrome-for-mac branch December 19, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant