Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flagging bidi enablement #1452

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

MohabMohie
Copy link
Contributor

user can now disable BiDi as it conflicts with certain non-standard grid implementations like moon and selenoid

Code: SHAFT.Properties.platform.set().enableBiDi(false);
Property file: enableBiDi=false
CommandLine: -DenableBiDi=false

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (61ad65f) 51.37% compared to head (d60775c) 50.97%.

Files Patch % Lines
.../driver/internal/DriverFactory/OptionsManager.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1452      +/-   ##
============================================
- Coverage     51.37%   50.97%   -0.40%     
+ Complexity     1312     1301      -11     
============================================
  Files           108      108              
  Lines         10229    10232       +3     
  Branches       1041     1042       +1     
============================================
- Hits           5255     5216      -39     
- Misses         4330     4375      +45     
+ Partials        644      641       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MohabMohie added a commit to ShaftHQ/shafthq.github.io that referenced this pull request Jan 15, 2024
implement bidi flag in alignment with ShaftHQ/SHAFT_ENGINE#1452

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Excluding MultipleBrowserInstancesTest as it breaks with Safari

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie merged commit 0254588 into main Jan 15, 2024
9 of 20 checks passed
@MohabMohie MohabMohie deleted the moonAndJunitAugmentedDriverSupport branch January 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant