Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1454 feature request jdk21 upgrade + virtual threads core rewrite #1455

Conversation

MohabMohie
Copy link
Contributor

No description provided.

- element identification algorithm will now attempt to capture all needed element information (5 code blocks) in parallel. This should speed up element identification significantly especially with remote executions.
@MohabMohie MohabMohie linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (07cc9da) 51.22% compared to head (d6dab44) 51.39%.
Report is 1 commits behind head on main.

Files Patch % Lines
...aft/gui/element/internal/ElementActionsHelper.java 64.23% 27 Missing and 22 partials ⚠️
...aft/gui/internal/image/ImageProcessingActions.java 25.00% 14 Missing and 1 partial ⚠️
...ain/java/com/shaft/gui/element/ElementActions.java 50.00% 8 Missing and 1 partial ⚠️
...m/shaft/tools/io/internal/ReportManagerHelper.java 65.38% 4 Missing and 5 partials ⚠️
src/main/java/com/shaft/cli/FileActions.java 55.55% 7 Missing and 1 partial ⚠️
.../com/shaft/tools/internal/security/GoogleTink.java 0.00% 6 Missing ⚠️
...ava/com/shaft/gui/element/AsyncElementActions.java 69.23% 4 Missing ⚠️
...performance/internal/LightHouseGenerateReport.java 0.00% 4 Missing ⚠️
...c/main/java/com/shaft/tools/io/PdfFileManager.java 42.85% 3 Missing and 1 partial ⚠️
...aft/tools/io/internal/ProjectStructureManager.java 63.63% 4 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1455      +/-   ##
============================================
+ Coverage     51.22%   51.39%   +0.17%     
- Complexity     1306     1321      +15     
============================================
  Files           108      108              
  Lines         10232    10191      -41     
  Branches       1042     1019      -23     
============================================
- Hits           5241     5238       -3     
+ Misses         4346     4315      -31     
+ Partials        645      638       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- created internal fileActions instances, to ensure no success logs are returned in case of successful internal calls
- using virtual threads to asynchronize ALL engine setup methods. NOTE: may cause issues with first time run
- engine setup time reduced to fraction of a second
@MohabMohie MohabMohie merged commit d53f002 into main Jan 16, 2024
25 of 26 checks passed
@MohabMohie MohabMohie deleted the 1454-feature-request-jdk21-upgrade-+-virtual-threads-core-rewrite branch January 16, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: JDK21 upgrade + Virtual Threads Core rewrite
1 participant