Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize actions to launch immediately #1458

Conversation

MohabMohie
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 315 lines in your changes are missing coverage. Please review.

Comparison is base (4fefdd0) 51.59% compared to head (868f4e1) 50.91%.
Report is 2 commits behind head on main.

Files Patch % Lines
...er/internal/DriverFactory/DriverFactoryHelper.java 40.44% 42 Missing and 11 partials ⚠️
...om/shaft/gui/internal/image/ScreenshotManager.java 45.91% 37 Missing and 16 partials ⚠️
...m/shaft/gui/internal/image/AnimatedGifManager.java 10.34% 50 Missing and 2 partials ⚠️
...ava/com/shaft/gui/element/AsyncElementActions.java 18.51% 22 Missing ⚠️
src/main/java/com/shaft/driver/DriverFactory.java 34.48% 16 Missing and 3 partials ⚠️
src/main/java/com/shaft/db/DatabaseActions.java 0.00% 18 Missing ⚠️
...com/shaft/gui/internal/image/ScreenshotHelper.java 72.72% 8 Missing and 7 partials ⚠️
...a/com/shaft/listeners/CucumberFeatureListener.java 0.00% 14 Missing ⚠️
...shaft/listeners/internal/TestNGListenerHelper.java 61.29% 6 Missing and 6 partials ⚠️
.../main/java/com/shaft/gui/element/TouchActions.java 16.66% 9 Missing and 1 partial ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1458      +/-   ##
============================================
- Coverage     51.59%   50.91%   -0.69%     
+ Complexity     1326     1288      -38     
============================================
  Files           108      108              
  Lines         10191    10070     -121     
  Branches       1019     1006      -13     
============================================
- Hits           5258     5127     -131     
- Misses         4296     4320      +24     
+ Partials        637      623      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

+ optimize logger file initialization
+ change allure back to the default reporter
@MohabMohie MohabMohie linked an issue Jan 22, 2024 that may be closed by this pull request
- screenshot logic optimization
- screenshot and animated gif classes restructure
- fix scaling issue with fullPageScreenshot using google cdp
- virtual thread implementation for faster waitForLazyLoading
-
@MohabMohie MohabMohie merged commit 7c6ef2c into main Jan 22, 2024
23 of 26 checks passed
@MohabMohie MohabMohie deleted the 1457-feature-request-optimize-async-element-actions-parallelization-and-add-cross-fluency-with-sync-actions branch January 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant