Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element verification rewrite #1466

Conversation

MohabMohie
Copy link
Contributor

No description provided.

@MohabMohie MohabMohie linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (74298c6) 50.98% compared to head (b220204) 50.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../shaft/validation/internal/ValidationsHelper2.java 76.31% 4 Missing and 5 partials ⚠️
...shaft/validation/internal/ValidationsExecutor.java 80.00% 4 Missing ⚠️
...n/internal/WebDriverElementValidationsBuilder.java 62.50% 3 Missing ⚠️
...m/shaft/validation/internal/ValidationsHelper.java 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1466      +/-   ##
============================================
- Coverage     50.98%   50.53%   -0.46%     
+ Complexity     1292     1282      -10     
============================================
  Files           108      109       +1     
  Lines         10069    10079      +10     
  Branches       1006     1012       +6     
============================================
- Hits           5134     5093      -41     
- Misses         4313     4357      +44     
- Partials        622      629       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohabMohie MohabMohie merged commit 702b7bf into main Jan 24, 2024
24 of 26 checks passed
@MohabMohie MohabMohie deleted the 1461-enhancement-revamp-validation-error-messages-using-stacktrace branch January 24, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Revamp validation error messages using stacktrace
1 participant