Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and enhancements #1473

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Fixes and enhancements #1473

merged 4 commits into from
Jan 28, 2024

Conversation

MohabMohie
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (ea0724e) 52.25% compared to head (585b706) 54.36%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ft/validation/internal/RestValidationsBuilder.java 62.50% 9 Missing ⚠️
...n/internal/WebDriverElementValidationsBuilder.java 50.00% 9 Missing ⚠️
...ft/validation/internal/JSONValidationsBuilder.java 0.00% 6 Missing ⚠️
src/main/java/com/shaft/cli/FileActions.java 66.66% 2 Missing ⚠️
...va/com/shaft/listeners/internal/UpdateChecker.java 77.77% 1 Missing and 1 partial ⚠️
.../validation/internal/NativeValidationsBuilder.java 94.44% 2 Missing ⚠️
.../shaft/validation/internal/ValidationsBuilder.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1473      +/-   ##
============================================
+ Coverage     52.25%   54.36%   +2.10%     
- Complexity     1332     1352      +20     
============================================
  Files           109      108       -1     
  Lines         10081     9962     -119     
  Branches       1015     1005      -10     
============================================
+ Hits           5268     5416     +148     
+ Misses         4188     3911     -277     
- Partials        625      635      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie merged commit 52eab71 into main Jan 28, 2024
27 checks passed
@MohabMohie MohabMohie deleted the fixes-and-enhancements branch January 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant