Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing assertions #1572

Merged
merged 13 commits into from
Apr 1, 2024
Merged

Testing assertions #1572

merged 13 commits into from
Apr 1, 2024

Conversation

MohabMohie
Copy link
Contributor

Assertions are behaving inconsistently and there are several UX issues and potential enhancements.

This PR will be one bulk PR to fix all assertions reporting... Estimated effort (Over 9000!)

here are some samples (before/after)

Element Attribute

Before

image

After

image

Element not found during assertion

Before

image

After

image

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 59.24051% with 322 lines in your changes are missing coverage. Please review.

Project coverage is 54.03%. Comparing base (1cec2d5) to head (bbf5f28).
Report is 2 commits behind head on main.

Files Patch % Lines
...ain/java/com/shaft/gui/element/ElementActions.java 56.28% 77 Missing and 3 partials ⚠️
.../main/java/com/shaft/gui/element/TouchActions.java 43.36% 60 Missing and 4 partials ⚠️
...m/shaft/validation/internal/ValidationsHelper.java 52.04% 33 Missing and 14 partials ⚠️
...ain/java/com/shaft/gui/browser/BrowserActions.java 53.75% 37 Missing ⚠️
...aft/gui/element/internal/ElementActionsHelper.java 55.76% 19 Missing and 4 partials ⚠️
.../shaft/validation/internal/ValidationsHelper2.java 83.47% 13 Missing and 6 partials ⚠️
...om/shaft/gui/internal/image/ScreenshotManager.java 52.94% 12 Missing and 4 partials ⚠️
...a/com/shaft/tools/internal/support/JavaHelper.java 60.00% 8 Missing and 4 partials ⚠️
.../main/java/com/shaft/gui/element/AlertActions.java 52.94% 8 Missing ⚠️
...m/shaft/driver/internal/FluentWebDriverAction.java 73.91% 6 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1572      +/-   ##
============================================
- Coverage     54.51%   54.03%   -0.48%     
+ Complexity     1372     1363       -9     
============================================
  Files           111      111              
  Lines          9910     9878      -32     
  Branches        974      956      -18     
============================================
- Hits           5402     5338      -64     
- Misses         3886     3925      +39     
+ Partials        622      615       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohabMohie MohabMohie merged commit b640aa9 into main Apr 1, 2024
38 of 42 checks passed
@MohabMohie MohabMohie deleted the testingAssertions branch April 1, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate / Nested reporting for assertions. Which is useless and should be cleaned.
2 participants