Fix VisualValidations issue #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BREAKING CHANGE: names will now end with the calling class name, and will not include the calling method name. - This means that one element will have one image no matter how many times you use it within the same calling class. - How does that impact you? your reference images will be updated after the first test run, and you are encouraged to delete your old reference images.
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
============================================
+ Coverage 26.82% 32.29% +5.47%
- Complexity 657 780 +123
============================================
Files 111 111
Lines 9940 9966 +26
Branches 961 966 +5
============================================
+ Hits 2666 3219 +553
+ Misses 6812 6203 -609
- Partials 462 544 +82 ☔ View full report in Codecov by Sentry. |
MohabMohie
deleted the
1588-bug-visual-validation-fails-on-subsequent-runs-with-w-and-h-must-be-0-error-130
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference image wasn't being read from the correct path in most scenarios causing a false positive or false negative state.