Fix: Ensure query parameters are added to requests with a body #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
============================================
- Coverage 54.45% 54.23% -0.23%
Complexity 1363 1363
============================================
Files 112 112
Lines 10010 10031 +21
Branches 973 971 -2
============================================
- Hits 5451 5440 -11
- Misses 3949 3979 +30
- Partials 610 612 +2 ☔ View full report in Codecov by Sentry. |
MohabMohie
reviewed
Jun 9, 2024
| } | ||
| """; | ||
| List<List<Object>> parameters = Arrays.asList(Arrays.asList("access_key", "your-access-key")); | ||
| @Test |
There was a problem hiding this comment.
Kindly comment this line to prevent the test from running in the pipeline.
There was a problem hiding this comment.
I deleted @test line
There was a problem hiding this comment.
Something is wrong my friend. Can you check the changed files tab? I can only see the test file.
There was a problem hiding this comment.
Both exist now (Test file and changes on RequestBuilder class)
MohabMohie
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where query parameters were not being added to requests that also have a body. It improves the performRequest method to ensure query parameters are correctly appended to the URL, along with enhancing error handling and modularizing the code.
src/main/java/com/shaft/api/RequestBuilder.java
When making HTTP requests with both query parameters and a request body, the query parameters were ignored, resulting in incorrect request URLs.
Dynamic URL Construction: Added functionality to append query parameters to the request URL, ensuring they are not lost when a body is present.
Comprehensive Error Management: Improved exception handling to manage errors during the request process effectively.
Modular Helper Methods: Created helper methods to append query parameters, check supported request types, and handle exceptions.
Linked Issue:
Fixes #1615