Rule database structure changes, and related diagnostic/doc changes. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 5, 2017 12:31
This restores consistency with how the other rule databases are handled from a diagnostic point of view.
no changes. This makes it easy+nice override another rule.
nearby PEP-8 violations.
The API to the rule database is now less abstract, and more opinionated to reduce the amount of boilerplate rule writers need to use. The explicit ability to add new rules reflects the model of having a core set of rules plus multiple additional sets (e.g. one per framework). The change also improves the way that rule-based diagnostic names are generated to match the new structure, making the diagnostic names reflect the use of the add_rules() mechanism.
|
While the use of github as way to send new changes can be acceptable for new contributors as new, the usage of pull request is cutting off the broader KDE community from the review process. Please use the proper tools for this. |
|
Hi Luigi,
Thanks for the feedback. I have responded in the thread back on the main
mailer.
…On 5 February 2017 at 21:39, Luigi Toscano ***@***.***> wrote:
While the use of github as way to send new changes can be acceptable for
new contributors as new, the usage of pull request is cutting off the
broader KDE community from the review process. Please use the proper tools
for this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEp7KdxcDtyxxsPTVM7DNoDzp6B8NgF6ks5rZkGigaJpZM4L3gpm>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits (dd33dfb and 18209a5) restore changes that got dropped from PR2 and PR3. The remaining commits are a fine-grained breakdown of PR4. I recommend reviewing the changes one commit at a time.