Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Make changes on backup command builder #321

Closed
ShahriyarR opened this issue Sep 23, 2018 · 1 comment
Closed

Make changes on backup command builder #321

ShahriyarR opened this issue Sep 23, 2018 · 1 comment

Comments

@ShahriyarR
Copy link
Owner

ShahriyarR commented Sep 23, 2018

There are too many duplicated code in xtrabackup command builder functionality also I am using hasattr():

# Checking if extra options were passed:
            if hasattr(self, 'xtra_options'):
                args += " "
                args += self.xtra_options

            # Checking if extra backup options were passed:
            if hasattr(self, 'xtra_backup'):
                args += " "
                args += self.xtra_backup

This can be achieved by using try/except.
Also these sections can be grouped together maybe. Will see.

@ShahriyarR
Copy link
Owner Author

Phase 1 is over and merged.
Will be released as part of v1.5.4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant