fix broken documentation examples #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix `as.list(data)` calls where `data` was not defined - even if `data` was defined, replace the symbol with `df` or `datalist` to avoid confusion in the future No R check ERRROS, WARNINGS, NOTES -- clean slate
|
Hi @ShanaScogin or @jayrobwilliams, could one of you please approve this pull request? It's just one commit and changes some examples in function documentations; it would be nice to have this in so that the branch where I'm working on generalizing mcmcRocPrc doesn't throw R check errors as I'm adding/testing things. |
|
Sure thing - we should be good to go. Thanks for finding all that! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #64: R check when run to ignore
\donttest{}produces several errors. That's fine for CRAN R check, but practically speaking it means some of the R man file examples won't work if a user tries them out.What I did:
as.list(data)calls wheredatawas not defineddatawas defined, replace the symbol withdfordatalistto avoid confusion in the futureNo R check ERRORS, WARNINGS, NOTES -- clean slate