Update for expression trees

Shane32 · Apr 10, 2024 · 0ca4619 · 0ca4619
1 parent f823901
commit 0ca4619
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 0 deletions.
diff --git a/src/Analyzers/DoNotCastIQueryableImplicitlyAnalyzer.cs b/src/Analyzers/DoNotCastIQueryableImplicitlyAnalyzer.cs
@@ -42,6 +42,19 @@ private void AnalyzeOperationAction(OperationAnalysisContext context)
                     return;
                 }
 
+                var parent = conversionOperation.Parent;
+                var checkedParents = new List<IOperation>();
+                while (parent != null) {
+                    if (checkedParents.Contains(parent)) {
+                        break;
+                    }
+                    checkedParents.Add(parent);
+                    if (parent.Type?.Name == nameof(System.Linq.Expressions.Expression)) {
+                        return;
+                    }
+                    parent = parent.Parent;
+                }
+
                 var diagnostic = Diagnostic.Create(
                     NoImplicitIQueryableCasts,
                     conversionOperation.Syntax.GetLocation(),

diff --git a/src/Tests/DoNotCastIQueryableImplicitlyAnalyzerTests.cs b/src/Tests/DoNotCastIQueryableImplicitlyAnalyzerTests.cs
@@ -164,4 +164,27 @@ public TestClass()
 
         await VerifyCS.VerifyAnalyzerAsync(source);
     }
+
+    [Fact]
+    public async Task IQueryable_WithinQuery()
+    {
+        const string source =
+            """
+            using System.Linq;
+
+            public class TestClass
+            {
+                public TestClass()
+                {
+                    var query = Enumerable.Empty<int>().AsQueryable();
+                    var query2 = query.Where(x => query.ToList().Count() > 5);
+                }
+            }
+            """
+        ;
+
+        await VerifyCS.VerifyAnalyzerAsync(source);
+    }
+
+    // todo: check for Queryable.Single and other non-async methods on IQueryable
 }
diff --git a/src/Tests/Tests.csproj b/src/Tests/Tests.csproj
@@ -6,6 +6,7 @@
     <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
     <IsPackable>false</IsPackable>
     <Nullable>enable</Nullable>
+    <NoWarn>$(NoWarn);IDE1006</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>