Skip to content

Commit

Permalink
bpo-40275: Remove test helpers aliases in test.support (pythonGH-21771)
Browse files Browse the repository at this point in the history
  • Loading branch information
shihai1991 committed Aug 8, 2020
1 parent a4084b9 commit d94af3f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 23 deletions.
3 changes: 2 additions & 1 deletion Lib/ctypes/test/test_loading.py
Expand Up @@ -6,6 +6,7 @@
import unittest
import test.support
from test.support import import_helper
from test.support import os_helper
from ctypes.util import find_library

libc_name = None
Expand Down Expand Up @@ -125,7 +126,7 @@ def test_load_dll_with_flags(self):
else:
ext = ".dll"

with test.support.temp_dir() as tmp:
with os_helper.temp_dir() as tmp:
# We copy two files and load _sqlite3.dll (formerly .pyd),
# which has a dependency on sqlite3.dll. Then we test
# loading it in subprocesses to avoid it starting in memory
Expand Down
23 changes: 4 additions & 19 deletions Lib/test/support/__init__.py
Expand Up @@ -14,25 +14,6 @@
import types
import unittest

from .import_helper import (
CleanImport, DirsOnSysPath, _ignore_deprecated_imports,
_save_and_block_module, _save_and_remove_module,
forget, import_fresh_module, import_module, make_legacy_pyc,
modules_cleanup, modules_setup, unload)
from .os_helper import (
FS_NONASCII, SAVEDCWD, TESTFN, TESTFN_ASCII, TESTFN_NONASCII,
TESTFN_UNENCODABLE, TESTFN_UNDECODABLE,
TESTFN_UNICODE, can_symlink, can_xattr,
change_cwd, create_empty_file, fd_count,
fs_is_case_insensitive, make_bad_fd, rmdir,
rmtree, skip_unless_symlink, skip_unless_xattr,
temp_cwd, temp_dir, temp_umask, unlink,
EnvironmentVarGuard, FakePath, _longpath)
from .warnings_helper import (
WarningsRecorder, _filterwarnings,
check_no_resource_warning, check_no_warnings,
check_syntax_warning, check_warnings, ignore_warnings)

from .testresult import get_test_runner


Expand Down Expand Up @@ -506,6 +487,7 @@ def check_syntax_error(testcase, statement, errtext='', *, lineno=None, offset=N

def open_urlresource(url, *args, **kw):
import urllib.request, urllib.parse
from .os_helper import unlink
try:
import gzip
except ImportError:
Expand Down Expand Up @@ -1326,6 +1308,8 @@ def skip_if_buggy_ucrt_strfptime(test):
class PythonSymlink:
"""Creates a symlink for the current Python executable"""
def __init__(self, link=None):
from .os_helper import TESTFN

self.link = link or os.path.abspath(TESTFN)
self._linked = []
self.real = os.path.realpath(sys.executable)
Expand Down Expand Up @@ -1980,6 +1964,7 @@ def skip_if_broken_multiprocessing_synchronize():
is no available semaphore implementation, or if creating a lock raises an
OSError (on Linux only).
"""
from .import_helper import import_module

# Skip tests if the _multiprocessing extension is missing.
import_module('_multiprocessing')
Expand Down
5 changes: 3 additions & 2 deletions Lib/test/test_os.py
Expand Up @@ -30,6 +30,7 @@
import uuid
import warnings
from test import support
from test.support import import_helper
from test.support import os_helper
from test.support import socket_helper
from test.support import threading_helper
Expand Down Expand Up @@ -2674,8 +2675,8 @@ def test_unlink_removes_junction(self):
@unittest.skipUnless(sys.platform == "win32", "Win32 specific tests")
class Win32NtTests(unittest.TestCase):
def test_getfinalpathname_handles(self):
nt = support.import_module('nt')
ctypes = support.import_module('ctypes')
nt = import_helper.import_module('nt')
ctypes = import_helper.import_module('ctypes')
import ctypes.wintypes

kernel = ctypes.WinDLL('Kernel32.dll', use_last_error=True)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_posixpath.py
Expand Up @@ -5,7 +5,7 @@
from test import test_genericpath
from test.support import import_helper
from test.support import os_helper
from test.support import FakePath
from test.support.os_helper import FakePath
from unittest import mock

try:
Expand Down

0 comments on commit d94af3f

Please sign in to comment.