Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to v1.2.9. Added some handling to stand inplace of the manual file corruption check. #207

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

J-Stuff
Copy link
Contributor

@J-Stuff J-Stuff commented Jun 24, 2023

After some more debugging, it looked best to fall back to v1.2.9 and add a try/except statement on the original line of code that was causing the errors in #191

The manual check with integv only caused issues in prod after the Dockerfile was built. So this should avoid it entirely.
(Shane, I thank you immensely for putting up with this tom-fuckery of an idea)

@J-Stuff
Copy link
Contributor Author

J-Stuff commented Jun 24, 2023

I found the issue in #191 was caused when recording using NVIDIA shadow play to the captures directory of Fireshare. Since the file was not fully "built" when fireshare attempted to scan the file.

@ShaneIsrael
Copy link
Owner

@J-Stuff No problem! Some improvements take a couple PR's to get right. I wish I had the time right now to help a bit more with it.

@ShaneIsrael ShaneIsrael merged commit af54272 into ShaneIsrael:develop Jun 25, 2023
@ShaneIsrael
Copy link
Owner

I'll leave it in the develop build for now, let me know if you think its all good and I'll merge to main and do another release.

@J-Stuff
Copy link
Contributor Author

J-Stuff commented Jun 25, 2023

Thanks. Would it be possible for a develop Docker Image to be built for testing. As I'm unable to build a working dockerfile for some reason.

@ShaneIsrael
Copy link
Owner

The develop branch has always had a docker image built when it is updated. its fireshare:develop, when you run it though the version will still reflect whatever the current main version is set to since I don't update develops version until I'm ready to make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants