Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPath interface to store XPath infomation #591

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add IPath interface to store XPath infomation #591

merged 2 commits into from
Nov 10, 2023

Conversation

BiDuang
Copy link
Contributor

@BiDuang BiDuang commented Nov 10, 2023 •
edited by pr-codex bot

PR-Codex overview

This PR focuses on adding the SDKXPath property to the IShape and ITextFrame interfaces, and implementing it in the corresponding classes.

Detailed summary

  • Added SDKXPath property to IShape interface.
  • Added SDKXPath property to ITextFrame interface.
  • Implemented SDKXPath property in SCShape and SCTextFrame classes.
  • Added GetXPath extension method to CompositeElementExtensions class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ashahabov ashahabov self-assigned this Nov 10, 2023
@ashahabov ashahabov merged commit f528377 into ShapeCrawler:master Nov 10, 2023
4 checks passed
@ashahabov
Copy link
Member

@BiDuang, I forget. Could you please also to add Unit Test.

@ashahabov ashahabov assigned BiDuang and unassigned ashahabov Nov 10, 2023
@BiDuang
Copy link
Contributor Author

BiDuang commented Nov 10, 2023

@BiDuang, I forget. Could you please also to add Unit Test.

Okay, just create a presentation and compare an element with a known path and the path obtained from SDKXPath property?

@ashahabov
Copy link
Member

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashahabov ashahabov ashahabov approved these changes

Assignees

@BiDuang BiDuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BiDuang @ashahabov