Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop iOS 3 support #151

Closed
sindresorhus opened this issue Dec 29, 2011 · 6 comments
Closed

Drop iOS 3 support #151

sindresorhus opened this issue Dec 29, 2011 · 6 comments

Comments

@sindresorhus
Copy link
Contributor

I propose ShareKit drop support for iOS 3.

iOS 3 was released summer 2009 and most people have upgraded.

Also, ARC requires at least iOS 4, if we want that in the near future.

@scompt
Copy link
Contributor

scompt commented Dec 29, 2011

There's at least one person using ShareKit on iOS 3 (see #147). On the plus side, dropping iOS 3 support would resolve that issue.

Are there any places in the code where you think the iOS 3 support is holding us back?

@VilemKurz
Copy link
Contributor

I am strongly in favor of dropping iOS 3.x. I stated that also in #147

@bluesuedesw
Copy link

I'm indifferent to keeping iOS 3 support around or not, however since currently there are only three pretty minor issues holding it back, it doesn't seem like it would get in the way of anything or be much work.

@VilemKurz
Copy link
Contributor

Yes, now we can cure the issues somehow. But the problem can be in future changes. I wonder if some people still have iOS 3 device around? And time to test on another environment, of course...

@sindresorhus
Copy link
Contributor Author

@scompt Not that I know of, but haven't really read the source, though there is probably some things that are deprecated now, better ways to do things, conditionals, etc.. Also current and future bugs, ARC, Blocks, ...

Marco Arment published some stats from his app Instapaper in November. It shows that 98.8% of his users have at least iOS 4.0. He recently set the minimum version to 4.3, with only one person complaining. Instapaper is a very popular app.

Another problem is that the iOS simulator in Xcode 4.2 doesn't have iOS 3, so we can't really test ShareKit on iOS 3 without a real device running it. And like @VilemKurz asked; does anyone still have an original iPhone/iPod touch?

We need to cut the cord sometime, why not know?

@VilemKurz
Copy link
Contributor

4.0 support added in prerequisites, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants