Fixed issue with missing headers in digest request. #465
Conversation
fela98
commented
May 20, 2017
fela98
commented
| Q | A |
|---|---|
| Bug fix? | [x] |
| New feature? | [ ] |
| New sample? | [ ] |
| Related issues? | fixes #464 |
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
Seriously? No comments, nothing? This fixes an in my opinion very critical bug which renders this library useless if you are using it outside of the SharePoint site and do any other requests than GET requests. It would be great to at least get some comments wether you think this is the right approach or not. |
|
Hi @fela98 - well, I've been on vacation and am just now trying to catch up on all the activities I have for my job, including my volunteer responsibilities for this repo. I haven't had a chance to look at this yet but will. Your contribution is appreciated but would also appreciate a little better approach to collaboration on your side. Thanks! |
|
I am sorry if I came across rude. I'm just trying to push this forward as our business depends heavily on this package, and this bug is currently a blocker for us. Keep up the good work! 👍 |
|
Merged, thanks for the PR - this will be rolled up into a beta release once I've been able to catch up with the issues list. |
