Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

RegionalSettings endpoint implementation, #649 #650

Merged
merged 1 commit into from
Nov 29, 2017
Merged

RegionalSettings endpoint implementation, #649 #650

merged 1 commit into from
Nov 29, 2017

Conversation

koltyakov
Copy link
Collaborator

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? implements #649

What's in this Pull Request?

This PR implements _api/web/RegionalSettings endpoint.

Guidance

 // Get regional setting
pnp.sp.web.regionalSettings.select('LocaleId,ShowWeeks').get().then(console.log);

// Get time zone
pnp.sp.web.regionalSettings.timeZone.get().then(console.log);

// Get time zones
pnp.sp.web.regionalSettings.timeZones.top(1).get().then(console.log);

// Get installed languages
pnp.sp.web.regionalSettings.installedLanguages.get().then(langs => {
  console.log(langs.Items[0]);
});

@patrick-rodgers
Copy link
Contributor

You should see the option to merge this now? If it looks good and you're good to merge it (same process for any PR - pull it down, test, lint, etc) you can. Only thing you need to do "special" is tag each PR that is merged with the upcoming milestone, in this case 3.0.3 which is the version it will eventually be released in. That helps me put all the notes together at the end of what we've done since the last release. I'll create the new milestone now and tag this. Let me know if you have any questions :)

@patrick-rodgers patrick-rodgers added this to the 3.0.3 milestone Nov 29, 2017
@koltyakov koltyakov merged commit 9520e8f into SharePoint:dev Nov 29, 2017
@koltyakov koltyakov deleted the dev-RegionalSettings branch November 29, 2017 15:02
@koltyakov
Copy link
Collaborator Author

Thanks, Patrick!

Yes, I have permissions for merging.
Good point about milestone tagging.

My workflow for dev and testing is following:

  • Local changes in dev/feature branch
  • Mapping src to sp-pnp-node and requesting live environment during development (like this - with ts-node ./runners/script_to_test.ts - just saves the time when debugging a specific method or use case)
  • Adjust tests for a use case
  • gulp test, if it's ok
  • And finally checking Travis results after posting PR

@patrick-rodgers
Copy link
Contributor

Yep, that's pretty much what I do as well. I also have a look at the code and make sure it fits with how we've done things within the rest of the library. so it "flows" with all the other code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants